Inherited protractor.By from webdriver.By #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return matches[0]; // We can only return one with webdriver.findElement. | ||
| function By () {} | ||
| function ByWrapper () {}; |
There was a problem hiding this comment.
Change these to
var By = function() {};
var ByWrapper = function() {};
juliemr
added a commit
that referenced
this pull request
Apr 24, 2013
Inherited protractor.By from webdriver.By
kbaltrinic
pushed a commit
to kbaltrinic/protractor
that referenced
this pull request
May 2, 2014
Inherited protractor.By from webdriver.By
This was referenced Mar 12, 2015
Closed
sjelin
pushed a commit
that referenced
this pull request
Jun 1, 2015
You can now give specific capabilities custom names so the output logs will be more understandable. For instance, you might name one capability "Chrome - French" and another "Chrome - English" so that the logs will read: [Chrome - French] ... [Chrome - French] ... [Chrome - French] ... [Chrome - English] ... [Chrome - English] ... [Chrome - English] ... Instead of just [chrome #1] ... [chrome #1] ... [chrome #1] ... [chrome #2] ... [chrome #2] ... [chrome #2] ... Closes #2112
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the By object in protractor to extend the By object from Selenium Webdriver. And then I updated all calls to webdriver.By in httpspec to now use protractor.By.