fix(debugger): fix issue where output does not display circular dep and ... #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| then(function() { | ||
| var result = execFn_(); | ||
| if (webdriver.promise.isPromise(result)) { | ||
| return result.then(function(val) {return val;}); |
There was a problem hiding this comment.
What was the reason for this in the past? It doesn't appear to do anything
There was a problem hiding this comment.
element(by.xyz).getText() is an elementFinder/promise.
When someone enters element(by.xyz).getText(), we need to return the text value of the elementFinder (i.e. by calling then) instead of the text representation of the elementFinder.
hankduan
force-pushed
the
fixelementexplorer
branch
from
8349cdb
to
6a28eb5
Compare
| execute: function(code) { | ||
| var execFn_ = function() { | ||
| // Run code through vm so that we can maintain a local scope which is | ||
| // isolated from the rest of the execution. | ||
| return vm_.runInThisContext(code); | ||
| var res = vm_.runInThisContext(code); | ||
| if(!webdriver.promise.isPromise(res)) { |
hankduan
force-pushed
the
fixelementexplorer
branch
from
6a28eb5
to
11fc94e
Compare
|
LGTM sorry for the delay |
|
merged in 5d23280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...functions