Add a slice method to ElementArrayFinder #2822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| * | ||
| * Note that if step is positive and start > stop, an error is thrown | ||
| * Note that if step is negative and start < stop, an error is thrown | ||
| * Note that slice(null,null,-1) will NOT produce a reversed array - use reverse() on the result instead. |
There was a problem hiding this comment.
This line is too long (80 max)
|
You're gonna need at least 1 test. Like the feature though! |
| } | ||
|
|
||
| return list; | ||
| }); |
There was a problem hiding this comment.
It looks like this got duplicated?
|
I'm cleaning up stale PRs and features, and closing this one. Please open a new PR/issue if you feel it's still valid. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have no way of taking a slice of all elements of an ElementArrayFinder. The slicing syntax is modelled after the slice syntax in python. ie : start defaults to 0, stop defaults to one past the last element in the array and step defaults to 1.