fix(launcher): Ignore uncaught exceptions from webdriver. #3608
Conversation
heathkit
force-pushed
the
3553-webdriver-exceptions
branch
from
ef85962
to
dded530
Compare
|
I'd like to have a test for this. I tried making a minimal custom test framework that would duplicate Cucumber's behavior. However, I wasn't able to come up with something that would both wait for all the WebDriver control flow promises to resolve, and also somehow throw webdriver errors as uncaught exceptions. |
heathkit
added
pr: needs review
pr: needs cleanup
and removed
pr: needs review
pr: needs cleanup
labels
| @@ -457,6 +457,13 @@ export interface Config { | |||
| */ | |||
| untrackOutstandingTimeouts?: boolean; | |||
|
|
|||
| /** | |||
| * If set, Protractor will ignore uncaught exceptions instead of exiting | |||
| * with | |||
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
heathkit
force-pushed
the
3553-webdriver-exceptions
branch
from
fd035eb
to
e89990c
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Could you please release? |
Fixes #3553.