Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

deps(jasmine): update jasmine to ^2.5.3 #3960

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

cnishina
Copy link
Member

  • Hot fix for overriding print function in jasmineNodeOpts

closes #3916

Copy link
Contributor

@sjelin sjelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine after rebasing. Not sure why you used ~ instead of ^ though

@@ -18,7 +18,7 @@
"blocking-proxy": "0.0.2",
"chalk": "^1.1.3",
"glob": "^7.0.3",
"jasmine": "2.4.1",
"jasmine": "~2.5.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "^2.5.3"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to respond to this. This could be ^2.5.3.

- Hot fix for overriding `print` function in `jasmineNodeOpts`

closes angular#3916
@cnishina cnishina changed the title deps(jasmine): update jasmine to ~2.5.3 deps(jasmine): update jasmine to ^2.5.3 Jan 30, 2017
@cnishina cnishina merged commit cd084a0 into angular:master Jan 30, 2017
igniteram pushed a commit to igniteram/protractor that referenced this pull request Feb 21, 2017
@cnishina cnishina deleted the deps_jasmine branch November 5, 2018 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jasmine dependency to allow users disable default reporter
3 participants