chore(browser): deprecate browser.getLocationAbsUrl().
#3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
reviewed
Jan 20, 2017
| @@ -938,6 +943,9 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver { | |||
| * AngularJS. | |||
| */ | |||
| getLocationAbsUrl(): wdpromise.Promise<any> { | |||
| logger.warn( | |||
| 'You are using `browser.getLocationAbsUrl()`, with is deprecated, inaccurately named, ' + | |||
There was a problem hiding this comment.
TMI, just "browser.getLocationAbsUrl() is deprecated, please use browser.getCurrentUrl` instead."
heathkit
reviewed
Jan 20, 2017
| * | ||
| * Dispite its name, this function will generally return `$location.url()`, though in some |
|
@mgiambalvo @juliemr all comments addressed |
juliemr
approved these changes
Jan 28, 2017
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
alopezsanchez
added a commit
to alopezsanchez/angular.js
that referenced
this pull request
Jun 14, 2017
…th browser.getCurrentUrl() According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
alopezsanchez
added a commit
to alopezsanchez/angular.js
that referenced
this pull request
Jun 14, 2017
…urrentUrl() According to angular/protractor#3969, browser.getLocationAbsUrl() is now deprecated and it recommends using browser.getCurrentUrl instead
gkalpak
pushed a commit
to angular/angular.js
that referenced
this pull request
Nov 15, 2018
…`browser.getCurrentUrl()` According to angular/protractor#3969, `browser.getLocationAbsUrl()` is now deprecated and `browser.getCurrentUrl()` should be used instead. Closes #16053
gkalpak
pushed a commit
to angular/angular.js
that referenced
this pull request
Nov 15, 2018
…`browser.getCurrentUrl()` According to angular/protractor#3969, `browser.getLocationAbsUrl()` is now deprecated and `browser.getCurrentUrl()` should be used instead. Closes #16053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3185