feat(browser): chain some promises in lib/browser.ts + return promi…
#4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se from `waitForAngularEnabled` Minor breaking change since `waitForAngularEnabled` no longer returns a boolean Part of angular#3904 Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
heathkit
reviewed
Jan 26, 2017
| @@ -109,8 +109,8 @@ function getNg1Hooks(selector, injectorPlease) { | |||
| return {$injector: $injector, $$testability: $$testability}; | |||
| } else { | |||
| return tryEl(document.body) || | |||
| trySelector('[ng-app]') || trySelector('[ng:app]') || | |||
| trySelector('[ng-controller]') || trySelector('[ng:controller]'); | |||
| trySelector('[ng-app]') || trySelector('[ng\\:app]') || | |||
There was a problem hiding this comment.
Today I learned something
heathkit
approved these changes
Jan 26, 2017
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Jan 27, 2017
…se from `waitForAngularEnabled` (angular#4021) Minor breaking change since `waitForAngularEnabled` no longer returns a boolean Part of angular#3904 Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…se from `waitForAngularEnabled` (angular#4021) Minor breaking change since `waitForAngularEnabled` no longer returns a boolean Part of angular#3904 Chaining `browser.get` has proved surprisingly complex, so I'll do that in a different PR Also fixed a minor bug in `lib/clientsidescripts.js` while debuging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se from
waitForAngularEnabledMinor breaking change since
waitForAngularEnabledno longer returns a booleanPart of #3904
Chaining
browser.gethas proved surprisingly complex, so I'll do that in a different PRAlso fixed a minor bug in
lib/clientsidescripts.jswhile debuging