fix(cli): Make unknown flag check a warning instead of an error #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
approved these changes
Jan 27, 2017
| logger, | ||
| 'Found extra flags: ' + unknownFlags.join(', ') + | ||
| ', please use --disableChecks flag to disable the Protractor CLI flag checks. '); | ||
| logger.warn('Ignoring unknown extra flags: ' + unknownFlags.join(', ')); |
There was a problem hiding this comment.
But a TODO and make an issue about reverting this change in 6.0
heathkit
force-pushed
the
check-warning
branch
from
64feff2
to
5d74c31
Compare
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.