fix(element chaining): make element chaining work when the control fl… #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow is disabled Also added some tests to `spec/ts/noCF/smoke_spec.ts` double checking that the control flow is off
|
This looks good to me and the tests are happy, so I'm good. Can you remind me which test was flaky without this? Is there a way we can force that test to always fail w/o this change, to improve testing? |
|
@juliemr The old flaky test was |
|
(you may have missed the new test because clang apparently reformatted the whole file) |
|
k, LGTM |
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…ow is disabled (angular#4029) Also added some tests to `spec/ts/noCF/smoke_spec.ts` double checking that the control flow is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ow is disabled
Also added some tests to
spec/ts/noCF/smoke_spec.tsdouble checking that the control flow is off@juliemr I know we talked offline and said it'd be best not to mess with
getWebElementand have chaining only work on value. But given functions likeisElementPresentandequalsandcount, it seems like there are going to be a lot of edge cases on that route and no clear dividing line on which functions should work and which shouldn't. This implementation is relatively clean, and should be very rigorously tested by our suite. So let me know.