fix(restart): preserve waitForAngularEnabled on restart and chain more promises together #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
changed the title
sjelin
force-pushed
the
restart_copy_sync
branch
from
a5ede78
to
54d5b23
Compare
…se chaining I noticed I missed `waitForAngularEnabled` in angular#4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
sjelin
force-pushed
the
restart_copy_sync
branch
from
54d5b23
to
e93b9b5
Compare
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
…se chaining (angular#4047) I noticed I missed `waitForAngularEnabled` in angular#4037. This commit fixed that. While I was at it I fixed a minor error where the promises implicitly created by setting `rootEl` and `ignoreSynchronization` weren't getting chained properly. Also fixed minor (so minor I think it was impossible to trigger) where browser.plugins_ could be undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in #4037
Also fixed a minor error where the promises implicitly created by setting
rootElandignoreSynchronizationweren't getting chained properly.Also fixed minor (so minor I think it was impossible to trigger) where
browser.plugins_ could be undefined.