chore(release): update selenium-webdriverjs and bump version number #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -23,7 +23,7 @@ | |||
| "optimist": "~0.6.0", | |||
| "q": "1.4.1", | |||
| "saucelabs": "~1.3.0", | |||
| "selenium-webdriver": "3.0.1", | |||
| "selenium-webdriver": "3.5.0", | |||
There was a problem hiding this comment.
It there any new features in 3.6.0 that you rely on?
There was a problem hiding this comment.
I was trying to search for the post of Simon Stewart but I couldn't find it. He said they didn't update the changelog (https://github.com/SeleniumHQ/selenium/blob/selenium-3.6.0/javascript/node/selenium-webdriver/CHANGES.md#vnext) but it was wise to update to 3.6.0 (on of the last versions before they are going to release version 4.0)
So if it's not to much effort I would advice to go to version 3.6.0
There was a problem hiding this comment.
OK, I will try it right now. If it is easy to upgrade to 3.6, I will upgrade protractor to 3.6 directly; otherwise, I 'll do it in a separate PR later on.
1.Update selenium-webdriverjs and bump version number 2.Solve compatibility problem: new webdriver has a more strict method when setting script timeout. If no script timeout was specified, set timeout to 0.
vikerman
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Update selenium-webdriverjs and bump version number
2.Solve compatibility problem: new webdriver has a more strict method when setting script timeout. If no script timeout was specified, set timeout to 0.