Feat(clientSideScripts): Add by.buttonText, by.partialButtonText

[Damiya]

Adds client side JS implementations of by.buttonText and
by.partialButtonText, enabling element lookup based on innerText.

Closes #452

[juliemr]

Automated CLA checker says: please sign CLA at http://code.google.com/legal/individual-cla-v1.0.html Please make sure that the email associated with your PR is the same as the email you use to sign.

[Damiya]

Done!

[juliemr]

CLA signature found, thank you!

[wlingke]

Big fan of this locator strategy @Damiya Thanks!

[elgalu]

I pulled this. Worked well on Chrome but failed on Firefox 26 (latest)

Error: No element found using locator: by.buttonText("Sign In")

Are protractor specs being tested against Firefox in Sauce Labs-TravisCI?

[Damiya]

Hey Leo,
Thanks for the report. I'll get my driver set up to include Firefox and
dig into it when I get a chance.

On 1/26/2014 10:44 AM, Leo Gallucci wrote:

I pulled this. Worked well on Chrome but failed on Firefox 26 (latest)

|Error: No element found using locator: by.buttonText("Sign In")
|

Are protractor specs being tested against Firefox in Sauce Labs-TravisCI?

—
Reply to this email directly or view it on GitHub
#455 (comment).

[cesarandreu]

This is awesome! Thanks @Damiya

[andresdominguez]

Can you add support for input type="button" and input type="submit"?

    by.addLocator('buttonText', function(parentElement, buttonText) {
      var using = parentElement || document,
          buttons = using.querySelectorAll(
              'button, input[type="button"], input[type="submit"]');

      return Array.prototype.filter.call(buttons, function(button) {
        var textContent = button.textContent;
        return textContent && textContent.trim() === buttonText;
      });
    });

[juliemr]

Thanks for your work on this - I'll accept if the cross-browser issues are fixed and the support that andres mentioned.

[Damiya]

PR updated, tested against IE11, Firefox 26, Chrome 33 locally.

Added the input searchers as well.

[elgalu]

This is great @Damiya ! Just pulled & tested by.buttonText('Sign In') and by.partialButtonText('Sign In') on a submit input in WIN8: IE9, IE10, FF26, CH32 and SauceLabs: IE9, FF26, CH31 on a heavy angular app :)

[Damiya]

Glad to hear it
On 1/31/2014 5:29 PM, Leo Gallucci wrote:

This is great @Damiya https://github.com/Damiya ! Just pulled &
tested |by.buttonText('Sign In')| and |by.partialButtonText('Sign
In')| on a submit input in WIN8: IE9, IE10, FF26, CH32 and SauceLabs:
IE9, FF26, CH31 on a heavy angular app :)

—
Reply to this email directly or view it on GitHub
#455 (comment).

[juliemr]

Thanks! Added a couple semicolons and merged as 88a1e58