This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(promises): remove q promises and webdriver promises #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cnishina
commented
Nov 22, 2018
cnishina
commented
- changes starting with cleaning up q promises and webdriver promises from plugins
|
This does not include the browser changes and I have doubts that the test suite will pass. |
|
Circle CI is passing... |
CrispusDH
reviewed
Nov 22, 2018
| @@ -93,7 +92,7 @@ let taskResults_ = new TaskResults(); | |||
| * @param {string=} configFile | |||
| * @param {Object=} additionalConfig | |||
| */ | |||
| let initFn = function(configFile: string, additionalConfig: Config) { | |||
| let initFn = async function(configFile: string, additionalConfig: Config) { | |||
| let configParser = new ConfigParser(); | |||
| if (configFile) { | |||
There was a problem hiding this comment.
do we need it check still here with TS? Probably, not.
There was a problem hiding this comment.
I am not sure. Could you clarify?
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
CrispusDH
reviewed
Nov 22, 2018
heathkit
reviewed
Nov 23, 2018
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
f62ffff
to
bf70a70
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
bf70a70
to
0a3b64b
Compare
heathkit
suggested changes
Nov 26, 2018
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
a098965
to
bf29861
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
bf29861
to
777a215
Compare
heathkit
approved these changes
Nov 26, 2018
cnishina
force-pushed
the
you_made_me_promises_promises
branch
6 times, most recently
from
5a2317e
to
d8b94fb
Compare
cnishina
force-pushed
the
you_made_me_promises_promises
branch
from
d8b94fb
to
4b57a18
Compare
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
- remove q promises and webdriver promises from the runner, launcher, plugins, and taskRunner - add deprecated message to element explorer. - add unhandledRejection - update browser versions used in travis tests
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
- remove q promises and webdriver promises from the runner, launcher, plugins, and taskRunner - add deprecated message to element explorer. - add unhandledRejection - update browser versions used in travis tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.