chore(test): error tests fixed #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
- Fix a missing await on createNextTaskRunner where the recursive call should be awaited and if there are no new tasks to still resolve the promise. Things were passing previously probably because we were running tasks out of sync. - Add in errorTest portion of the test suite - Turn on the angular2 and unit tests. - Turn on browserstack test in Travis.
cnishina
force-pushed
the
AdderrorTests
branch
from
b64a8df
to
4c61e6e
Compare
heathkit
approved these changes
Nov 30, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
- Fix a missing await on createNextTaskRunner where the recursive call should be awaited and if there are no new tasks to still resolve the promise. Things were passing previously probably because we were running tasks out of sync. - Add in errorTest portion of the test suite. - Turn on the angular2 and unit tests. - Turn on browserstack test and remove ciNg2Conf test from Travis.
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
- Fix a missing await on createNextTaskRunner where the recursive call should be awaited and if there are no new tasks to still resolve the promise. Things were passing previously probably because we were running tasks out of sync. - Add in errorTest portion of the test suite. - Turn on the angular2 and unit tests. - Turn on browserstack test and remove ciNg2Conf test from Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be awaited and if there are no new tasks to still resolve the
promise. Things were passing previously probably because we were
running tasks out of sync.