deps(selenium): upgrade to selenium 4 #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #5084 |
CrispusDH
reviewed
Dec 17, 2018
This was referenced Dec 17, 2018
cnishina
force-pushed
the
upgrade_selenium4
branch
3 times, most recently
from
5266394
to
d4ce192
Compare
heathkit
reviewed
Dec 18, 2018
| tsc(); | ||
| test('tmp/conf.js'); | ||
| test('tmp/typescript_conf.js'); | ||
| // test('tmp/conf.js'); |
There was a problem hiding this comment.
Do these tests not work anymore?
There was a problem hiding this comment.
The entire install script does not work. We need to rethink this whole thing.
heathkit
approved these changes
Dec 18, 2018
- Elements workaround for WebElement.equals - Added a better unhandled rejection warning message in the launcher - Remove global function wrappers for mocha (these wrappers went away with control flow) - Fix the attach to session driver provider Typing exported from Protractor: - removed ActionSequence and EventEmitter - removed promise.Promise - removed Promise, defer, delayed, createFlow, controlFlow, all, fulfilled, filter, when Typings exported from WebDriver: - removed attachToSession - removed WebDriver instance methods: touchActions, call - removed WebElement getSize and getLocation for getRect - removed redefined global vars for testing Tests: - Fix element equals - Add missing 'await' in colorList test. This caused unhandled promise rejections. - Remove control flow related tests - Disable the install test. Installing from "file:../../" is not working. - Fix the attach to session driver provider test to exit with a 1 if errors are encountered
cnishina
force-pushed
the
upgrade_selenium4
branch
3 times, most recently
from
aa14fdf
to
545c0d7
Compare
cnishina
force-pushed
the
upgrade_selenium4
branch
from
545c0d7
to
c6ec28b
Compare
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
- elements workaround for WebElement.equals - added a better unhandled rejection warning message in the launcher - remove global function wrappers for mocha (these wrappers went away with control flow) - fix the attach to session driver provider Typing exported from Protractor: - removed ActionSequence and EventEmitter (actions is currently missing) - removed promise.Promise - removed Promise, defer, delayed, createFlow, controlFlow, all, fulfilled, filter, when Typings exported from WebDriver: - removed attachToSession - removed WebDriver instance methods: touchActions, call - removed WebElement getSize and getLocation for getRect - removed redefined global vars for testing - In the typings, we are missing Options.setScriptTimeout method. This should not impact users unless they are using the driver.manage() method. Tests: - fix element equals test - add missing 'await' in colorList test that is causing unhandled promise rejections. - remove control flow related tests - disable the install test. Installing from "file:../../" is not working. - fix the attach to session driver provider test to exit with a 1 if errors are encountered
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
- elements workaround for WebElement.equals - added a better unhandled rejection warning message in the launcher - remove global function wrappers for mocha (these wrappers went away with control flow) - fix the attach to session driver provider Typing exported from Protractor: - removed ActionSequence and EventEmitter (actions is currently missing) - removed promise.Promise - removed Promise, defer, delayed, createFlow, controlFlow, all, fulfilled, filter, when Typings exported from WebDriver: - removed attachToSession - removed WebDriver instance methods: touchActions, call - removed WebElement getSize and getLocation for getRect - removed redefined global vars for testing - In the typings, we are missing Options.setScriptTimeout method. This should not impact users unless they are using the driver.manage() method. Tests: - fix element equals test - add missing 'await' in colorList test that is causing unhandled promise rejections. - remove control flow related tests - disable the install test. Installing from "file:../../" is not working. - fix the attach to session driver provider test to exit with a 1 if errors are encountered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control flow)
Typing exported from Protractor:
fulfilled, filter, when
Typings exported from WebDriver:
Tests:
rejections.
working.
errors are encountered
closes #5095