refactor to fix lints. #5184
Merged
refactor to fix lints. #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrispusDH
reviewed
Mar 24, 2019
lib/runnerCli.ts
Outdated
| break; | ||
| default: | ||
| throw new Error('command ' + m.command + ' is invalid'); | ||
| if (m.command == 'run') { |
There was a problem hiding this comment.
It might be better to use === instead of ==
cnishina
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following lints :
1. refactor(launcher): removes unnecessary assignment
Removes unnecessary assignment of
shortName@ line 582. refactor(runnerCli): convert
switchtoif-elseConverts the
switchto anif-elseas theswitchstatement is made of only 2 branches. 馃槃