feat(elementFinder): keep a reference to the original locator #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var byBinding = by.binding('greet'); | ||
| expect(byCss).toEqual(element(byCss).locator()); | ||
| expect(byBinding).toEqual(element(byBinding).locator()); | ||
| }); |
There was a problem hiding this comment.
I'm not sure what I was expecting, I think I misunderstand the use case here. For some reason I was thinking something like this:
expect(by.css('body').locator()).toEqual('body');
expect(by.css('body').strategy()).toEqual(by.css);There was a problem hiding this comment.
The idea of returning the {webdriver.Locator} type is having all its original flexibility back:
$('body').locator(); //=>
{ using: 'css selector', value: 'body' }
element(by.model('username')).locator(); //=>
{ findElementsOverride: [Function],
message: 'by.model("username")' }
|
Looks good. I would actually label this a feature since it's adding something to the API. I'll make the tiny change I mentioned and merge. |
|
Merged as b93bf18 |
elgalu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some reasons to expose the reference to the original webdriver.Locator, @Droogans for example shows one here
I personally need this because sometimes i find myself using webdriver directly, i.e.
browser.driver.xxxxand for that reason i'm unable to use certain shortcuts like$('a.thing')within my page objects, usingby.css('a.thing')then wrapping the locator withelement()when needed.Being able to do
element(aThing).locator()will give the flexibility back.