Unwrap ES2015+ classes when using TypeScript 3.9 #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes that contain TypeScript Decorators and/or static properties will be wrapped in an IIFE when using TypeScript 3.9. This transformer will remove the wrapping to allow analysis by closure compiler.
|
First of all, thanks for the PR! This is something that is definitely blocking adoption of TypeScript 3.9 for codebases using tsickle. We were hoping to land a compiler option in upstream TypeScript to deal with this rather than relying on their implementation and rewriting it. Having the option there will keep tsickle-flavored emit closer to upstream emit, and less divergence will be good for future maintainability. In the meantime, please follow the tracking issue in the TypeScript repo for updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes that contain TypeScript Decorators and/or static properties will be wrapped in an IIFE when using TypeScript 3.9. This transformer will remove the wrapping to allow analysis by closure compiler.
Tested against TypeScript 3.9.2 in combination with the changes in #1143