be careful around type aliases in @implements #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's legal to @implements a type alias, but we need to be careful to not @implements a type alias that maps back to a symbol that we didn't emit a type for due to the symbol being both a type and a value. Yikes! To ensure I got this right, I added both a test for: - implementing an ordinary interface via an alias - a more complex reproduction of the zone issue Fixes #333 harder.
evmar
commented
Jan 20, 2017
| /** @typedef {!Interface} */ | ||
| var TypeAlias; | ||
| /** | ||
| * @implements {TypeAlias} |
There was a problem hiding this comment.
Note: here is where we successfully implement a type alias.
| } | ||
| /** @typedef {?} */ | ||
| var ZoneAlias; | ||
| class ZoneImplementsAlias { |
There was a problem hiding this comment.
And this class (and the one above it) both don't @implements anything, due to the interface not existing.
rkirov
approved these changes
Jan 21, 2017
evmar
added a commit
that referenced
this pull request
Jan 26, 2017
The "Zone" library uses a pattern that is deeply incompatible with tsickle in such a way that making this work is hard. For now, let's revert @implements so that we can move forward on importing TS2.1. This reverts: 660f4c0 be careful around type aliases in @implements (#336) 2255b53 don't emit @implements on non-types (#334) c9fc5c8 add @implements tag on "implements" clauses (#329)
LucasSloan
pushed a commit
that referenced
this pull request
Feb 2, 2017
The "Zone" library uses a pattern that is deeply incompatible with tsickle in such a way that making this work is hard. For now, let's revert @implements so that we can move forward on importing TS2.1. This reverts: 660f4c0 be careful around type aliases in @implements (#336) 2255b53 don't emit @implements on non-types (#334) c9fc5c8 add @implements tag on "implements" clauses (#329)
LucasSloan
pushed a commit
that referenced
this pull request
Feb 3, 2017
The "Zone" library uses a pattern that is deeply incompatible with tsickle in such a way that making this work is hard. For now, let's revert @implements so that we can move forward on importing TS2.1. This reverts: 660f4c0 be careful around type aliases in @implements (#336) 2255b53 don't emit @implements on non-types (#334) c9fc5c8 add @implements tag on "implements" clauses (#329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's legal to @implements a type alias, but we need to be careful
to not @implements a type alias that maps back to a symbol that
we didn't emit a type for due to the symbol being both a type
and a value. Yikes!
To ensure I got this right, I added both a test for:
Fixes #333 harder.