fix enum export by upgrading closure compiler #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum EnumTest1 {XYZ, PI = 3.14159} | ||
|
|
||
| export enum EnumTest2 {XYZ, PI = 3.14159} |
There was a problem hiding this comment.
OOC what difference does export make?
There was a problem hiding this comment.
Actually, maybe add a comment to explain why an exported enum needs separate testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wrote "export enum ...", the generated ES6 JavaScript would
fail to compile in the Closure compiler. I tracked this down to
a bug that was fixed in the upstream Closure compiler, so to fix
this I had to make us use a newer version of the upstream compiler.
To use a newer version of the upstream compiler, I removed one of
our indirection layers: we previously used the 'closure-compiler'
npm library which pulled in 'google-closure-compiler', but now the
latter module exposes a simple API so it's easy enough to just use
it directly.
Fixes issue #50.