Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@nguniversal/common): add Window stubs to Engine (Clover) #2117

Merged
merged 1 commit into from
May 20, 2021
Merged

fix(@nguniversal/common): add Window stubs to Engine (Clover) #2117

merged 1 commit into from
May 20, 2021

Conversation

alan-agius4
Copy link
Collaborator

Closes #2108

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels May 20, 2021
@google-cla
Copy link

google-cla bot commented May 20, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@angular angular deleted a comment from googlebot May 20, 2021
CaerusKaru
CaerusKaru approved these changes May 20, 2021
View reviewed changes
modules/common/clover/server/src/stubs.ts
function noop(): void {}

export function augmentWindowWithStubs(window: DOMWindow): void {
window.resizeBy = noop;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow users to pass in their own versions? My instinct says there's no utility there but who knows. Approving without it, so up to you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it in the future, if there is the need for it. In general we should avoid increasing the API without a completing reason.

@alan-agius4 alan-agius4 added the action: merge PR author is ready for this to merge label May 20, 2021
@alan-agius4 alan-agius4 merged commit 635d61e into angular:master May 20, 2021
@alan-agius4 alan-agius4 deleted the stubs branch May 20, 2021 12:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru CaerusKaru approved these changes

Assignees
No one assigned
Labels
action: merge PR author is ready for this to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Clover] jsdom: Mocks for element scrolling methods are missing
3 participants
@alan-agius4 @CaerusKaru @googlebot