fix(common): add serverTarget for prerender
#2123
Conversation
alan-agius4
added
action: cleanup
target: patch
There was a problem hiding this comment.
Actually, this is not the correct schematic, the problematic one is https://github.com/angular/universal/blob/master/modules/express-engine/schematics/install/index.ts
The changes here should be reverted
Add `serverTarget` for the prerender architect in the install schematic Closes #2120
| @@ -118,9 +118,11 @@ function updateWorkspaceConfigRule(options: AddUniversalOptions): Rule { | |||
| configurations: { | |||
| production: { | |||
| browserTarget: `${options.project}:build:production`, | |||
| serverTarget: `${projectName}:server:production`, | |||
| }, | |||
| development: { | |||
| browserTarget: `${options.project}:build:development`, | |||
There was a problem hiding this comment.
Mind changing this to projectName? 😀
alan-agius4
added
action: merge
|
@alan-agius4 you mean to change |
|
Other way. |
|
My browser was idle and I did not notice that the PR was actually merged 😁 Should I make a separate PR for the change that you propose? |
|
Sure, feel free to do a refactor PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add
serverTargetfor the prerender architect in the add schematicCloses #2120