New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@nguniversal/builders): spawn static server for build artifacts #2141

Merged

alan-agius4 merged 1 commit into angular:master from lacolaco:proposal-clover-transfer-assets

Jun 1, 2021

Contributor

lacolaco commented May 29, 2021

Using express to spawn a local static server for browser build artifacts which allows HTTP requests to a relative path like /assets/data.json while rendering.

Close #2132

cc/ @alan-agius4

lacolaco requested review from alan-agius4, CaerusKaru and kyliau as code owners

May 29, 2021 12:37

google-cla bot added the cla: yes label

lacolaco force-pushed the proposal-clover-transfer-assets branch 2 times, most recently from cdfaf58 to 79c2982 Compare

May 29, 2021 14:06

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/prerender/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/prerender/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/prerender/utils.spec.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/prerender/render.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/package.json Outdated Show resolved Hide resolved

Collaborator

alan-agius4 commented May 31, 2021

Can you please add a basic test in https://github.com/angular/universal/blob/master/integration/clover/test.js?

alan-agius4 reviewed

View reviewed changes

Collaborator

alan-agius4 left a comment

Couple of small NITS.

Thanks for this @lacolaco.

Contributor Author

lacolaco commented May 31, 2021

@alan-agius4 Thank you for the review. I've fixed all that was pointed out. BTW, unfortunately, promisify(app.listen) that you suggested doesn't work as expected.

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

modules/builders/src/static-generator/index.ts Outdated Show resolved Hide resolved

alan-agius4 reviewed

View reviewed changes

integration/clover/test.js Outdated Show resolved Hide resolved

alan-agius4 approved these changes

View reviewed changes

Collaborator

alan-agius4 left a comment

Last couple of things.

Can you also please squash? Thanks.

alan-agius4 added the target: minor label

lacolaco force-pushed the proposal-clover-transfer-assets branch 2 times, most recently from 87cd779 to 787878d Compare

May 31, 2021 14:09


          feat(@nguniversal/builders): spawn static server for build artifacts

f0c6733

lacolaco force-pushed the proposal-clover-transfer-assets branch from 787878d to f0c6733 Compare

May 31, 2021 14:14

Contributor Author

lacolaco commented May 31, 2021

CI test fails due to unrelated files. Is it a flaky test?

Collaborator

alan-agius4 commented May 31, 2021

CI test fails due to unrelated files. Is it a flaky test?

Looks like it.

alan-agius4 approved these changes

View reviewed changes

Collaborator

alan-agius4 left a comment

Thanks again.

alan-agius4 added the action: merge label

alan-agius4 merged commit 8982199 into angular:master

lacolaco deleted the proposal-clover-transfer-assets branch

June 1, 2021 10:52

angular-automatic-lock-bot bot commented Jul 2, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.