-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to Defination not working #1753
Comments
It's not working to for me to, I'll sahere more details of VSC installed in my pc: Version: 1.71.0 (user setup) |
I installed the previous version of the VSCode extension (14.2.0) which resolved the issue for now at least |
It's 14.1.0, not 14.2.0 |
Same problem but in "recent" version of angular (>11), if i open the ts file, the html file find the definition (before no...) |
Is this still an issue? Using the latest version of the extension and the latest version of VSCode, I'm unable to reproduce this issue. There's not any more information than the versions being used and I can't reproduce the issue using the same versions.
Angular projects using v2-v11 are not supported anymore. See https://angular.io/guide/releases#support-policy-and-schedule |
Hi @atscott, |
@chandan192 Are you saying that the extension version 14.1.0 doesn't work with v14.2 projects or that the language service extension version 14.2.0 does not work with Angular projects of various versions? |
@atscott I meant to say the language service extension v14.1.0 is working fine. It has the issue with the extension v14.2.0. |
@chandan192 Got it. Can you provide a project to reproduce this issue? I was not able to reproduce it in my own projects. |
@atscott Same comment as @chandan192, some of our projects are old and no longer very maintained and use old versions of Angular but it worked perfectly in 14.1.0. Version : 1.71.2 (user setup) Project : |
Based on the few comments here for project version, the issue is limited to older projects. We make a best effort to be backwards compatible, but this is not always possible. For older projects, I have pinpointed the breakage to the commit which updated the TypeScript version. This necessary for the extension to work with 14.2. Older projects should install a previous version of the language service that has a bundled TypeScript version compatible with the project. Again, backwards compatibility is a goal but not always possible. The extension version always aims to be compatible with the corresponding version of Angular (14.2 compatible with 14.2, 11 compatible with 11). You can always go back and install the matching extension version for your project (or a newer version with more features, provided it's still compatible). Closing as working as expected. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Go to defination is not working with Angular Language Service v14.2.0.
Error - No config file for ....
Visual Studio Code
Version: 1.71.0
Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
Date: 2022-09-01T07:25:10.472Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.4.0-125-generic
Sandboxed: No
The text was updated successfully, but these errors were encountered: