Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Defination not working #1753

Closed
chandan192 opened this issue Sep 11, 2022 · 12 comments
Closed

Go to Defination not working #1753

chandan192 opened this issue Sep 11, 2022 · 12 comments
Labels

Comments

@chandan192
Copy link

Go to defination is not working with Angular Language Service v14.2.0.

Error - No config file for ....

Visual Studio Code
Version: 1.71.0
Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
Date: 2022-09-01T07:25:10.472Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.4.0-125-generic
Sandboxed: No

@chandan192 chandan192 added the bug label Sep 11, 2022
@MartinhoMCM
Copy link

MartinhoMCM commented Sep 12, 2022

It's not working to for me to, I'll sahere more details of VSC installed in my pc:

Version: 1.71.0 (user setup)
Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
Date: 2022-09-01T07:36:10.600Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

@tedp
Copy link

tedp commented Sep 12, 2022

I installed the previous version of the VSCode extension (14.2.0) which resolved the issue for now at least

@liumaowen
Copy link

I installed the previous version of the VSCode extension (14.2.0) which resolved the issue for now at least

It's 14.1.0, not 14.2.0

@xtoussaint-estel
Copy link

Same problem but in "recent" version of angular (>11), if i open the ts file, the html file find the definition (before no...)
In old angular projet (<9) it never find.
I don't have another project with others versions of angular to try...

@atscott
Copy link
Collaborator

atscott commented Sep 19, 2022

Is this still an issue? Using the latest version of the extension and the latest version of VSCode, I'm unable to reproduce this issue. There's not any more information than the versions being used and I can't reproduce the issue using the same versions.

In old angular projet (<9) it never find.

Angular projects using v2-v11 are not supported anymore. See https://angular.io/guide/releases#support-policy-and-schedule

@chandan192
Copy link
Author

Hi @atscott,
The angular version is 8.2.14. I guess the problem might be with lower versions of angular as mentioned by @xtoussaint-estel.
But point to mention is the angular language service v14.1.0 was perfectly working. It has the issue with the latest version v14.2.0.

@atscott
Copy link
Collaborator

atscott commented Sep 19, 2022

@chandan192 Are you saying that the extension version 14.1.0 doesn't work with v14.2 projects or that the language service extension version 14.2.0 does not work with Angular projects of various versions?

@chandan192
Copy link
Author

@atscott I meant to say the language service extension v14.1.0 is working fine. It has the issue with the extension v14.2.0.

@atscott
Copy link
Collaborator

atscott commented Sep 19, 2022

@chandan192 Got it. Can you provide a project to reproduce this issue? I was not able to reproduce it in my own projects.

@xtoussaint-estel
Copy link

@atscott Same comment as @chandan192, some of our projects are old and no longer very maintained and use old versions of Angular but it worked perfectly in 14.1.0.
I tested again this morning with 14.2.0, still the same problem with old projects but no longer with projects >= 11 O_O

Version : 1.71.2 (user setup)
Validation : 74b1f979648cc44d385a2286793c226e611f59e7
Date : 2022-09-14T21:03:37.738Z
Electron : 19.0.12
Chromium : 102.0.5005.167
Node.js : 16.14.2
V8 : 10.2.154.15-electron.0
Système d’exploitation : Windows_NT x64 10.0.19044
Sandboxé : No

Project :
Angular CLI: 8.3.29
Node: 14.17.0
OS: win32 x64
Angular: 8.2.14
(OK... It's old... but extension 14.1.0 works perfectly)

@atscott
Copy link
Collaborator

atscott commented Sep 20, 2022

Based on the few comments here for project version, the issue is limited to older projects. We make a best effort to be backwards compatible, but this is not always possible. For older projects, I have pinpointed the breakage to the commit which updated the TypeScript version. This necessary for the extension to work with 14.2.

Older projects should install a previous version of the language service that has a bundled TypeScript version compatible with the project. Again, backwards compatibility is a goal but not always possible. The extension version always aims to be compatible with the corresponding version of Angular (14.2 compatible with 14.2, 11 compatible with 11). You can always go back and install the matching extension version for your project (or a newer version with more features, provided it's still compatible).

Closing as working as expected.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants