Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues between Angular 9 and Angular Language Service 17.x #2030

Closed
1 task
manusoftar opened this issue May 3, 2024 · 2 comments
Closed
1 task
Labels

Comments

@manusoftar
Copy link

🐞 bug report

Is this a regression?

Yes, the previous version in which this bug was not present was: 11.1.2

Description

I was working on a a project based on Angular 9 and another project based on Angular 15, the extension automatically selected version 17.x, it had no issues as far as I could see with the Angular 15 project but it completely broke the older project.

If the bug is caused or experienced by a particular source code, please provide a minimal
reproduction of that source code.

Bug Type

What does this bug affect

  • [ x ] Angular Language Service VSCode extension
  • Angular Language Service server

Reproduction

Steps to reproduce the behavior:

Just create an Angular 9 project with ngx-bootstrap and ngx-toastr and node 14.20.0 with this extension installed (version 17.x) and it will show alledged errors on app.modules.ts which are not actually true and if you try to fix those false issues you may end up breaking the whole project (like it happened to me)

Expected behavior

I would expect this extension to be retrocompatible with older Angular versions, actually, I would expect it to get the propper angular version from the project itself and not present these kind of errors.

@manusoftar manusoftar added the bug label May 3, 2024
@atscott
Copy link
Collaborator

atscott commented May 3, 2024

Angular 9 has long been dropped from LTS and is not guaranteed to be compatible with the most recent versions of the language service. The extension uses the Angular compiler and cannot guarantee infinite backwards compatibility. Instead, you should install a version of the extension that is closer to that of the project.

@atscott atscott closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants