Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents renaming folders (Windows) #240

Closed
tflanitzer opened this issue Mar 29, 2018 · 10 comments
Closed

Prevents renaming folders (Windows) #240

tflanitzer opened this issue Mar 29, 2018 · 10 comments

Comments

@tflanitzer
Copy link

tflanitzer commented Mar 29, 2018

I have noticed that I cannot rename folders within my project as long as the language service is active. This is the error I get when I try:

2018-03-29 10_02_47-inbox - thomas flanitzer zuehlke com - outlook

As soon as I deactivate the extension and reload, it works as expected.

Using Process explorer I found out that indeed Code.exe has open handles on each folder in my project:

2018_03_29_10_07_57_data_import_editor component ts_frontend_visual_studio_code_administrator_

Here is the Angular Language Service log output:

Search path: c:/dev/XXX/Sources/Frontend/src/app/data-import/data-import-editor
Config file name: c:/dev/XXX/Sources/Frontend/tsconfig.json
Angular Language Service: 5.1.0
TypeScript: 2.6.2
getTemplateRefrences: 2942ms
Add recursive watcher for: c:/dev/XXX/Sources/Frontend
Opened configuration file c:/dev/XXX/Sources/Frontend/tsconfig.json
getDiagnostics: 20ms
@Darkein
Copy link

Darkein commented Feb 18, 2019

Hello,
the problem is still here. I have to deactivate this extension to rename my files and folders on Windows 10.

@jonaskuske
Copy link

Same issue. :(

@techy2493
Copy link

This is a much larger issue than just renaming, the service is leaving open file handles all over the place. I'm having trouble deleting things, re-building projects with libraries that npm link & unlink, git rebases... It's gotten worse recently, which may be partly due to windows updates but the extension itself is keeping these handles open.

@techy2493
Copy link

image
This is an example of attempting to rebase with the extension on, (after failing and re-starting VsCode) and below is an example after the extension is disabled in the worksapce.
image

@techy2493
Copy link

Here is an example where the Angular Language Service blocks an NPM Unlink of a package library due to these same open file handles.
image

@techy2493
Copy link

These things separately impact workflow and performance, but when working quickly in large projects these things together make working with the angular language service enabled nearly impossible.

@Darkein
Copy link

Darkein commented Jun 19, 2019

This issue is opened since more than one year, and this annoying problem is still here (I just can't use this great extension).
What do you need to take a look on it ?

@JohnnyDevNull
Copy link

Well i have also the problems since a long time and the plugin in the actual state is in bigger projects especially with local angular libraries not usable. I have disabled it and work without it.

I think the problem is the duplicate TS-Server which is running and maybe it's fixed with that one here: #338

@kyliau
Copy link
Contributor

kyliau commented Nov 23, 2019

This is the same as #224, will track the issue there.

@kyliau kyliau closed this as completed Nov 23, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants