Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Suspicious code in promise.ts #1168

@shicks

Description

@shicks

promise && (promise = null || resolve(value));

promise && (promise = null || reject(error));

I'm rolling out a new lint check and discovered some suspicious code in promise.ts. In the above snippets, null is always falsy, so it is ignored. It can be simplified to simply promise = resolve(value) or promise = reject(value).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions