registerElement should support callbacks coming from deep prototype chains

[rkirov]

The following line:

zone.js/zone.js

Line 663 in 26a4dc2

var descriptor = Object.getOwnPropertyDescriptor(opts.prototype, callback);

Checks if (opts.prototype[callback]) and then uses Object.getOwnPropertyDescriptor(opts.prototype, callback) to retrieve it. If the callback comes from the prototype chain we cannot use getOwnPropertyDescriptor.

[btford]

+1

On Sun, Mar 1, 2015 at 3:30 PM Rado Kirov notifications@github.com wrote:

The following line:

zone.js/zone.js

Line 663 in 26a4dc2

var descriptor = Object.getOwnPropertyDescriptor(opts.prototype, callback);

Checks if (opts.prototype[callback]) and then uses Object.getOwnPropertyDescriptor(opts.prototype,
callback);. If the callback comes from the prototype chain we cannot use
getOwnPropertyDescriptor.

—
Reply to this email directly or view it on GitHub
#52.

[tkhemani]

Hi,
I tried to run the "youtube-app" demo, but it's failing at this line. I see that you've mentioned this:

need to be patched

• zone.js
  • registerElement should support callbacks coming from deep prototype chains #52 (need to patch locally in node_modules/zone.js)
• angular 2
  • Compiler cannot reliably know element properties ahead of time  angular#776 (need to patch locally)

Can you please share the patch...

[kingcody]

I encountered this issue as well (when dealing with polymer elements, see here).

@tkhemani, its not very elegant or heavily tested but here was my solution.

[tkhemani]

@kingcody . Thanks, I got the youtube-app working after @rkirov shared the patches. But i'm still not able to get a simple polymer button working inside an angular 2.0 component directive. Can you possibly try it out.

[kingcody]

@tkhemani Working in FF, but not in Chrome.

[tkhemani]

@kingcody, are you saying u were able to get a polymer button working inside an angular 2.0 component directive? Can you share the code.

[JoshAntBrown]

I'm having this issue too, again like @kingcody when dealing with polymer elements but this time the Google Web Component ones.

I did see a pull request at #31 which looks like it might have tried to fix the problem but implementing their code into my project stopped the console error but still didn't render the component. I also tried the solution posted in here before but same result as the pull request.

They do work in FF but not Chrome for some reason though.

[jianliao]

@JoshAntBrown Yes, there is no such issue in FF, but it seems to me the property binding like this

[hidden]="!active" 

does not work. The reason that customer element does not work in Chrome is probably due to angular/angular#1442

[justinfagnani]

Yes, you need a fix for both the zone.js and Angular issues before custom elements work. I have all this working locally, but don't have time to put together a tested PR.

[vicb]

@justinfagnani you can send me "some" code and I'll try to clean and PR if you like