This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix #569, request will cause updateTaskCount failed if we call abort … #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you describe the error case in the commit message / inline comment and squash the commits ? |
JiaLiPassion
force-pushed
the
issue-287
branch
from
151fb59
to
50ac4fd
Compare
|
@vicb, thank you for the review, I have added inline comment and squash the commits, please review. |
… abort multipletimes the fix is check whether the xhr has been aborted before abort the request
JiaLiPassion
force-pushed
the
issue-287
branch
from
50ac4fd
to
7eb10fd
Compare
|
@vicb can this be merged? Really need this fix so I can get rid of those annoying console messages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #287, #569.