This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(jasmine): support "pending" it clauses with no test body
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Mar 3, 2017
lib/jasmine/jasmine.ts
Outdated
| return testProxyZone.run(testBody, this, [done]); | ||
| } : function() { |
There was a problem hiding this comment.
If we always return a function, won't it essentially make all specs non-pending (since there will be a callback specified)?
I think this should be:
return testBody && ((testBody.length == 0) ? function() { ... } : function { ... });There was a problem hiding this comment.
Not sure how to test that easily...
Due to the lack of lockfile, a clean install resulted in dependencies that caused the tests to fail. This commit is a vain attempt to lock down dependencies (or at least the direct ones).
petebacondarwin
force-pushed
the
jasmine-fix-1
branch
from
55eec95
to
49e8e9a
Compare
mhevery
reviewed
Mar 7, 2017
| @@ -79,7 +79,7 @@ | |||
| "ts-loader": "^0.6.0", | |||
| "tslint": "^4.1.1", | |||
| "tslint-eslint-rules": "^3.1.0", | |||
| "typescript": "^2.0.2", | |||
| "typescript": "2.1.x", | |||
There was a problem hiding this comment.
We have to upgrade TS in a separate PR.
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
mhevery
pushed a commit
that referenced
this pull request
Mar 7, 2017
|
Just ran into this issue today. Would love to use it. Any idea on the timeline for the next release cut? |
|
released
…On Wed, Mar 8, 2017 at 8:27 AM, Andrew Smith ***@***.***> wrote:
Just ran into this issue today. Would love to use it. Any idea on the
timeline for the next release cut?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#659 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAG1T1JPU-aM8tAQ4s4FOALIA04YYBgWks5rjtbtgaJpZM4MSF_2>
.
|
|
Many Thanks!
… On Mar 12, 2017, at 1:00 PM, Miško Hevery ***@***.***> wrote:
released
On Wed, Mar 8, 2017 at 8:27 AM, Andrew Smith ***@***.***>
wrote:
> Just ran into this issue today. Would love to use it. Any idea on the
> timeline for the next release cut?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#659 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAG1T1JPU-aM8tAQ4s4FOALIA04YYBgWks5rjtbtgaJpZM4MSF_2>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.