refactor!: remove SlowComponentLoader and ReflectiveInjector. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to enforce conventional commit now, so if you want to squash & merge this PR as one big commit, please rename the PR title (which will become the commit title) when you submit this as ready for review. Otherwise, when submitting, please rebase/edit/squash/force push or whatever you like to ensure individual commits follow conventional commit guidelines. |
ykmnkmi
changed the title
GZGavinZhao
reviewed
Sep 10, 2022
_tests/test/di/directive_test.dart
Outdated
| @@ -4,6 +4,19 @@ import 'package:test/test.dart'; | |||
|
|
|||
| import 'directive_test.template.dart' as ng; | |||
|
|
|||
| Object missingServicFactory(Object willNotBeCalled) { | |||
|
Just one small thing, in the function I commented on, did you mean to type |
|
Yes. |
GZGavinZhao
pushed a commit
that referenced
this pull request
Sep 14, 2022
…lowComponentLoader and ReflectiveInjector (#26)
GZGavinZhao
pushed a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove
SlowComponentLoader,ReflectiveInjectorclasses with dependentrunAppLegacy,runAppLegacyAsyncandbootstrapStaticfunctions.