Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lifecycle (onchanges -> afterchanges) #40

Conversation

genesistms
Copy link
Contributor

No description provided.

@genesistms genesistms mentioned this pull request Mar 24, 2022
4 tasks
@genesistms genesistms marked this pull request as draft March 24, 2022 08:16
@GZGavinZhao
Copy link
Contributor

If the site doesn't build locally, that's my problem here. I'll get it sorted tonight.

@GZGavinZhao
Copy link
Contributor

Done. I still have to fix some stuff with toh-6, but now the site should compile without problems.

@GZGavinZhao
Copy link
Contributor

Nice work so far! One thing though: do not modify anything in <?code-excerpt> directly. This part is automatically updated/generated by our code excerpt generation tool. If you need to change the files, change their relevant example Dart project located in examples/ng/doc/<project-name>. For example, if you're working on lifecycle hooks, update the code inside examples/ng/doc/lifecycle-hooks. The corresponding source file name is included in the <?code-excerpt> block. After that, run grind create-code-excerpts and grind update-code-excerpts.

Also, the code in lifecycle-hooks is very out-to-date. If you're having trouble running and building that project, I'll take care of that tomorrow.

@genesistms
Copy link
Contributor Author

I am getting errors due to missing toh-6 directory.

@genesistms
Copy link
Contributor Author

I am going to update whole lifecycle article. But for now, deprecation of OnChanges is the first step.

@GZGavinZhao
Copy link
Contributor

GZGavinZhao commented Mar 25, 2022

Refetch the Git submodules: git submodule update --init --remote --recursive.

You can also enable CI in your fork if it's costly to build the site locally.

@GZGavinZhao
Copy link
Contributor

Looks good to me so far. I can help generate the GIFs this weekend if I can fix my PC before that.

@@ -3,13 +3,13 @@ description: Lifecycle Hooks
version: 0.0.1

environment:
sdk: '>=2.5.0 <3.0.0'
sdk: '>=2.12.0 <3.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a 2.12 SDK to check whether Angular 7 can actually run for Dart versions below 2.14? I think theoretically Angular 7 is only for 2.14+ (see here), but I never verified it by myself.

@GZGavinZhao GZGavinZhao marked this pull request as ready for review April 13, 2022 03:10
@genesistms genesistms changed the title Update Lifecycle (onchanges -> afterchanges) [WIP] Update Lifecycle (onchanges -> afterchanges) Apr 13, 2022
@GZGavinZhao GZGavinZhao merged commit c3b6ecd into angulardart-community:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants