Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old chart always visible if new data is empty #148

Merged
merged 2 commits into from
Mar 10, 2014

Conversation

julienmeyer
Copy link
Contributor

Temporaray workaround to solve issue novus/nvd3#349

@cmaurer
Copy link
Contributor

cmaurer commented Mar 7, 2014

@julienmeyer Can you fix your pull request? The travis ci build failed.

Thanks,
Chris

[L860:C53] W116: Expected '===' and instead saw '=='.
      if ( angular.isArray( data ) && data.length == 0 ) {

@julienmeyer
Copy link
Contributor Author

Done

@cmaurer
Copy link
Contributor

cmaurer commented Mar 10, 2014

@julienmeyer Cool. Thanks.

Chris

cmaurer added a commit that referenced this pull request Mar 10, 2014
Old chart always visible if new data is empty
@cmaurer cmaurer merged commit d0500ab into angularjs-nvd3-directives:master Mar 10, 2014
@umair-khanzada
Copy link

@julienmeyer what about if data updated and old chart doesn't remove !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants