🐛 Fix unit abbreviation lookup for unit value cast to Enum #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1301
When looking up unit abbreviation for a unit enum value that is cast to
Enum
, for example via variable or method parameter, the lookup failed due to usingtypeof(TUnitEnum)
in the generic method.Enum
satisfies the generic constraint, but the generic type no longer describes the original unit enum type. Instead, we must useunitEnumValue.GetType()
.Changes
Enum
type is passed instead of an actual unit enum type