🛡️Restrict number extension methods to INumber<T> #1281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269
Quantities implement
IConvertible.ToDouble()
by converting theValue
property todouble
, and similar for other number types.Number extension methods expects a number argument, but take any argument type and call
Convert.ToDouble()
on it. This means you can run into subtle bugs:The quantity implements conversions like this:
The extension method looks like this:
So
Convert.ToDouble()
happily convertsLength.FromCentimeters(100)
to100
.Changes
INumber<T>
for net7.0 and later