Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-jQuery dependent Waypoint-like method to track analytics within div scrolling #140

Closed
stvhanna opened this issue May 26, 2014 · 11 comments

Comments

@stvhanna
Copy link

It would be nice to not have to use jQuery and the jQuery.Waypoint plugin to track analytics of elements passing through the viewport as they are scrolled by within a scrollable div container/parent (not Window/Document).

I've found https://github.com/thenikso/angular-inview, which doesn't require jQuery, but I'm not sure how to integrate it. Anyone has some suggestions on a way to do this? I'd greatly appreciate it. :)

@websirnik
Copy link

+1. Very supportive of the idea of dropping jQuery.

@timelf123
Copy link
Contributor

I'm all for dropping jQuery as well, but unfortunately https://github.com/thenikso/angular-inview requires you to place directives in-vew all over your layout a la

<my-directive in-view="{expression using $inview}"></my-directive>

$inview evaluates to true or false depending on if it is in view. Pretty straightforward, but seems a bit verbose.

It seems to me that some people will still want to use the jQuery plugin - if that's the case, how do we manage the bower dependencies as far as jQuery vs a new provider that is raw Angular?

@dlecan
Copy link

dlecan commented Sep 15, 2014

how do we manage the bower dependencies

You need to split angulartics into several components:

  • angulartics-core
  • angulartics-scroll-inview
  • angulartics-scroll-jquery
  • ...

@rayshan
Copy link

rayshan commented Oct 18, 2014

+1

Most angular components are moving towards no query dependency, e.g. angular-strap

@stramel
Copy link

stramel commented Nov 25, 2014

+1

@timelf123
Copy link
Contributor

This will be fixed in 1.X

@stramel
Copy link

stramel commented Nov 25, 2014

@timelf123 Awesome, I will be definitely be awaiting that release. Do you have a general idea of when that would be making an appearance? Looking at the 1.x branch seems like it hasn't had much progress lately.

@luisfarzati
Copy link
Member

We just started splitting plugins off the core. This includes jQuery and waypoints. See #377 and https://github.com/angulartics/angulartics-google-analytics

@hermansje
Copy link

Waypoints works with adapters now, and has added support for usage with Zepto or without any DOM framework.

@luisfarzati
Copy link
Member

Great, so we'll move the scroll tracking off the core and remove jQuery in the process.

@martinmcwhorter
Copy link

+1 Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants