Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issue: some .js files are missing license headers #378

Closed
ktiedt opened this issue Jul 9, 2015 · 2 comments
Closed

minor issue: some .js files are missing license headers #378

ktiedt opened this issue Jul 9, 2015 · 2 comments

Comments

@ktiedt
Copy link

ktiedt commented Jul 9, 2015

As stated, minor, we run license checks for third party code and our compiler complains about ~4 or so files, I'll have to go back to get the list, but I was hesitant to submit a PR for this since some of the files are contributed by others, and such the license block reads a bit different (giving credit where it is due obviously). It wasnt immediately obvious if this was the case for these files.

@luisfarzati
Copy link
Member

Please check out the list and let me know. Anyway, we are moving the plugins into their own repo and I'm removing those license headers in the files. I put contribution credits in package.json and probably will do the same in the LICENSE file, but no longer in source files.

@timelf123
Copy link
Contributor

Closing, please reopen or file a new issue if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants