Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Application Insights plugin and sample #290

Closed
wants to merge 1 commit into from

Conversation

anthonychu
Copy link

/**
* Numeric properties are sent as metric (measurement) properties.
* Everything else is sent as normal properties.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this provider before, but isn't it too much to assume all numeric properties are always metrics? Isn't there a case where I would like to track just a normal numeric property?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunks Good point. I've thought about this and one idea was to provide a setting to specify a suffix to use to indicate a property is a metric. For example, if the suffix is "metric"...

<button analytics-on analytics-category="Commands"  
    analytics-label="Button4 label" 
    analytics-numeric-value-metric="1">Button 4</button>

The provider will strip off the suffix before sending to Azure. And maybe by default the suffix is null and it'll automatically send numerics as metrics.

Do you have any other ideas to approach this? Thanks.

@luisfarzati
Copy link
Member

I think it becomes too verbose, but being vendor-specific, I don't really care much. If you @anthonychu are ok with that, it's cool. I don't see any other complaining here, so :)

We are in the process of moving all plugins off the core and into their own repo (see #377) so no longer is accepted PRs for plugins. Instead, I'd appreciate if you create a repo for this plugin on your side and make sure to comply with the plugin contribution rules.

Once you have everything ready, let us know and if everything's right we can adopt the plugin into the Angulartics org.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants