Add support for UI Router 1.0 which will use transition hooks #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of state events.
timelf123
added a commit
that referenced
this pull request
Mar 1, 2016
…on-hooks Add support for UI Router 1.0 which will use transition hooks
|
Thank you @CrispyBacon12 for landing this so quickly! |
|
@CrispyBacon12 are you using 1.0.0beta ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #454.
For tests, I've mocked the $transitions dependency instead of writing it as an integration, since UI Router 1.0 isn't released to bower yet. Let me know your thoughts on how to test against the pre-release if mocks isn't what you want.
Cheers