Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 12 support #402

Closed
Shereef opened this issue Nov 24, 2020 · 11 comments · Fixed by #430
Closed

Angular 12 support #402

Shereef opened this issue Nov 24, 2020 · 11 comments · Fixed by #430
Labels

Comments

@Shereef
Copy link

Shereef commented Nov 24, 2020

I'm submitting a ...

  • [X ] feature request

  • What is the expected behavior?
    Support for Angular 12

  • What is the motivation / use case for changing the behavior?
    Being on the latest version and reaping the benefits of the new features and security patches

  • Environment:
    All

please run the following and copy the output

./node_modules/.bin/ng --version
 _                      _                 ____ _     ___
/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | '_ \ / | | | | |/ _ | '__| | | | | | |
/ ___ | | | | (
| | || | | (| | | | || | | |
// __| ||_, |_,||_,|| _|||
|___/

Angular CLI: 10.2.0
Node: 12.16.3
OS: win32 x64

Angular: 10.2.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, platform-server, router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1002.0
@angular-devkit/build-angular 0.1002.0
@angular-devkit/core 10.2.0
@angular-devkit/schematics 10.2.0
@angular/cdk 10.2.7
@angular/cli 10.2.0
@angular/material 10.2.7
@angular/material-moment-adapter 10.2.7
@schematics/angular 10.2.0
@schematics/update 0.1002.0
rxjs 6.6.3
typescript 4.0.5

@ebussieres
Copy link

ebussieres commented Jan 25, 2021

Any plan to upgrade to Angular 11 soon ?

@ericsoucy
Copy link

Do it! :)

@helgetan
Copy link

any updates here?

@jbjhjm
Copy link

jbjhjm commented Jun 14, 2021

Special: 2 for 1 offer! :O Let's update to Angular 12 :)
I guess there's nothing to be changed technically, just peer dependency version has to be updated.

@Shereef Shereef changed the title Angular 11 support Angular 12 support Jun 14, 2021
@Shereef
Copy link
Author

Shereef commented Jun 14, 2021

Updated the title to Angular 12

@scttcper
Copy link
Collaborator

scttcper commented Oct 7, 2021

hey yall, i have merge access, but not access to publish to npm. Because travis-ci stopped building we would need to setup a new CI with an up to date token to publish a new version.

I don't know if anyone is still around to bring this project back.

@scttcper scttcper pinned this issue Oct 7, 2021
@JonnyBGod
Copy link
Collaborator

@scttcper I just gave you admin access to the repository.

I just checked and apparently travis turn of the .org site and now we have to use the .com. I just requested access to the repository but I do not manage angulartics org so it might take some time.

Maybe it would be best to move to Github actions.

I don't have the time these days to help much but feel free to take it from here.

@scttcper
Copy link
Collaborator

scttcper commented Oct 7, 2021

@JonnyBGod nice! thanks!

Can you add me as a collaborator on the npm package as well? https://docs.npmjs.com/adding-collaborators-to-private-packages-owned-by-a-user-account This way i can setup github actions or another ci with it. My username on npm is the same.

Looks like npm/github is having issues at the moment

edit: maybe this is the right docs page https://docs.npmjs.com/cli/v7/commands/npm-owner

@JonnyBGod
Copy link
Collaborator

@scttcper sorry for the delay, can you check if you have access now on npm?

@scttcper
Copy link
Collaborator

@JonnyBGod looks good thanks! should be unblocked from here

scttcper added a commit that referenced this issue Oct 17, 2021
- upgrade to angular 12
- switch to eslint

BREAKING CHANGE: requires angular >= 12
BREAKING CHANGE: drops support for ui-router
BREAKING CHANGE: All providers are now in the core package `'angulartics2/ga'` is now just `import { Angulartics2GoogleAnalytics } from 'angulartics2'`

closes #402
@github-actions
Copy link

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants