Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just-merge/just-extend any object. #71

Closed
DylanPiercey opened this issue Oct 22, 2017 · 2 comments
Closed

just-merge/just-extend any object. #71

DylanPiercey opened this issue Oct 22, 2017 · 2 comments

Comments

@DylanPiercey
Copy link
Contributor

DylanPiercey commented Oct 22, 2017 •
edited

Looks like the last release changed just-extend to have an object type check.

I personally use the utility for functions like so:

function MyPerfectLib () {}
const statics = { ... }

extend(MyPerfectLib, statics)

It'd be nice if this could be supported again.

Edit: Also this a breaking change and published as a patch release.
@freaktechnik freaktechnik mentioned this issue Oct 22, 2017
Closed
@angus-c
Copy link
Owner

angus-c commented Oct 22, 2017

Sorry, this was totally unintentional and fixed in v1.1.26. Intention was to provide prompt/clear error info if you passed a primitive arg. Did not mean to exclude functions!

@angus-c angus-c closed this as completed Oct 22, 2017
@DylanPiercey
Copy link
Contributor Author

No problem, thanks for the quick fix!

maoberlehner pushed a commit to maoberlehner/unit-testing-vue-components-with-ava that referenced this issue Oct 23, 2017
Update dependencies
9e70c9e 
This fixes a problem with Sinon.JS related to
angus-c/just#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angus-c @DylanPiercey