Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add capitalize #123

Merged
merged 4 commits into from
Mar 12, 2019
Merged

add capitalize #123

merged 4 commits into from
Mar 12, 2019

Conversation

antony
Copy link
Contributor

@antony antony commented Feb 27, 2019

This hopefully fits the format you expect.

@angus-c
Copy link
Owner

angus-c commented Feb 27, 2019

Thanks!

I think we should lower-case all other letters as lodash does. https://lodash.com/docs/#capitalize

So 'ALL CAPS' -> 'All caps'

@angus-c
Copy link
Owner

angus-c commented Feb 27, 2019

Also can you add a similar README section in the root level README.

@antony
Copy link
Contributor Author

antony commented Feb 28, 2019

@angus-c sure thing :)

@angus-c angus-c merged commit ee1749b into angus-c:master Mar 12, 2019
@angus-c
Copy link
Owner

angus-c commented Mar 12, 2019

Thanks!!

@bakkot bakkot mentioned this pull request Mar 12, 2019
Closed
@antony antony deleted the capitalise branch March 12, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antony @angus-c