Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine social and tiles #55

Merged
merged 25 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@merefield
Copy link
Collaborator

commented Feb 13, 2019

This PR fully replaces social style with tiles style now that it works on mobile and desktop and will operate in one column if you restrict the available width.

@merefield merefield requested a review from angusmcleod Feb 15, 2019

@angusmcleod

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2019

@merefield On first load, I'm getting an exception.

screen shot 2019-02-18 at 9 23 38 am

You'll need to add a check for tags existence before iterating through them.

if (Discourse.SiteSettings.topic_list_tiles_larger_featured_tiles && topic.tags.filter(function (tag) {
                return _this.get('featuredTags').indexOf(tag) > -1;
              })[0]) {
                this.classNames.push('tiles-grid-item-width2');
              }

However, let's just break this out into a new PR. One feature per PR is best.

@merefield

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 17, 2019

Ok will do on both counts.

merefield added some commits Feb 18, 2019

Revert "NEW FEATURE: double sized tiles for featured Topics"
Will be moved to new PR.

This reverts commit e226d3b.
restoring previous additional call to masonry as experimental fix to …
…avoid layout corruption in produciton (that doesn't show in development)
Revert "restoring previous additional call to masonry as experimental…
… fix to avoid layout corruption in produciton (that doesn't show in development)"

Didn't resolve issue

This reverts commit 7cbe8cb.
@angusmcleod
Copy link
Owner

left a comment

I'm getting this exception when opening the category settings modal. Check that you've updated how the custom settings are initialized
screen shot 2019-02-28 at 11 11 29 am

I'm also seeing a number of remaining "social" or "social-style" strings in the plugin. Let's clean these up.

screen shot 2019-02-28 at 11 18 21 am

@merefield

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 28, 2019

Apologies, this is all done.

@merefield merefield requested a review from angusmcleod Feb 28, 2019

@merefield merefield referenced this pull request Feb 28, 2019

Closed

Featured tiles #66

@angusmcleod angusmcleod merged commit ffff336 into angusmcleod:master Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.