New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine social and tiles #55
Merged
angusmcleod
merged 25 commits into
paviliondev:master
from
merefield:combine_social_and_tiles
Feb 28, 2019
Merged
Combine social and tiles #55
angusmcleod
merged 25 commits into
paviliondev:master
from
merefield:combine_social_and_tiles
Feb 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@merefield On first load, I'm getting an exception. You'll need to add a check for tags existence before iterating through them.
However, let's just break this out into a new PR. One feature per PR is best. |
Ok will do on both counts. |
angusmcleod
requested changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ter, updated name for meta plugin outlet, removed social field from serializer
Apologies, this is all done. |
Closed
angusmcleod
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully replaces social style with tiles style now that it works on mobile and desktop and will operate in one column if you restrict the available width.