Added check in ServiceProvider's register and boot methods to see if … #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we are on terminal, then do not register and boot. Why? because, if we add no-captcha to the project at the very beginning or say before generating application key (artisan key:generate), then artisan key:generate will throw an error of "RuntimeException No application encryption key has been specified." because of the use of Encryption class, which itself require application key.
Updating with upstream repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…we are on terminal, then do not register and boot.
Why? because, if we add no-captcha to the project at the very beginning or say before generating application key (artisan key:generate), then artisan key:generate will throw an error of "RuntimeException No application encryption key has been specified." because of the use of Encryption class, which itself require application key.