-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reducer store logic and add missing dependencies in package.json #102
Fix reducer store logic and add missing dependencies in package.json #102
Conversation
Awesome Work Man ! |
Give me some time to review this ! 😃 |
Shouldn't we remove the complete public/ folder and add it to the .gitignore ? |
🤘 |
Ok either way works fine 👍 |
Also, since the webpack chunks out the (bundle) bin/server.js as well (along with the other files in the public/ folder), do we remove that as well and add to the .gitignore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions
Remove them ! #102 (comment) |
Also, why did this PR drop the code coverage by 0.3% here? I am not able to figure out correctly 🤔 |
Leave it, I guess it may be because of modern js codes...not supportable. |
Done remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors please add @ypahalajani for infrastructure, code, doc and bug |
I've put up a pull request to add @ypahalajani! 🎉 |
This PR addresses #23