Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add webpack files to webpack folder (fixes #133) #151

Merged
merged 4 commits into from
Jul 12, 2020

Conversation

Ckbhatia
Copy link
Contributor

@Ckbhatia Ckbhatia commented May 27, 2020

fixes #133

@Ckbhatia
Copy link
Contributor Author

@anikethsaha Please review the changes, Inform me if there is need for any changes

Copy link
Owner

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR.

The changes looks good. One note

can we rename the webpack folder with .webpack . (leading dot)

@Ckbhatia
Copy link
Contributor Author

What is the benefit of that?

@anikethsaha
Copy link
Owner

No benifits in particular, but it states that it contains configurations for the project.

like .github folder

@anikethsaha anikethsaha changed the title Add webpack files to webpack folder fix: add webpack files to webpack folder (fixes #133) May 27, 2020
@Ckbhatia
Copy link
Contributor Author

Changes have been made

@anikethsaha anikethsaha reopened this May 27, 2020
@anikethsaha
Copy link
Owner

netlify deployement is failing. Can you check that locally if there is any issue with running the scripts.

@Ckbhatia
Copy link
Contributor Author

No, I have verified the changes before pushing. 👍

@anikethsaha
Copy link
Owner

No, I have verified the changes before pushing. 👍

umm, I will check this soon 👍

@Ckbhatia
Copy link
Contributor Author

Hey,
Did you check?

@anikethsaha
Copy link
Owner

I will check this soon. A bit busy for few coming days

@Ckbhatia
Copy link
Contributor Author

Ckbhatia commented Jun 5, 2020

Bro, it's been 8 days. Can you please review now?

@Ckbhatia
Copy link
Contributor Author

@anikethsaha Can you check now?

@anikethsaha
Copy link
Owner

I will check this weekend.

Thank you for your patience

@Ckbhatia
Copy link
Contributor Author

Bro, I think, contributed to a dead project.

@anikethsaha
Copy link
Owner

apologies for delay.

Did you test locally is there any issue in that ? I didn't check locally, have some issue with my current OS config.

@Ckbhatia
Copy link
Contributor Author

I had checked when I fixed this. It was working fine.

@anikethsaha anikethsaha merged commit 6cb4944 into anikethsaha:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refacore: Move all webpack.*.js to .webpack folder
2 participants