-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add webpack files to webpack folder (fixes #133) #151
Conversation
@anikethsaha Please review the changes, Inform me if there is need for any changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR.
The changes looks good. One note
can we rename the webpack
folder with .webpack
. (leading dot)
What is the benefit of that? |
No benifits in particular, but it states that it contains configurations for the project. like |
Changes have been made |
netlify deployement is failing. Can you check that locally if there is any issue with running the scripts. |
No, I have verified the changes before pushing. 👍 |
umm, I will check this soon 👍 |
Hey, |
I will check this soon. A bit busy for few coming days |
Bro, it's been 8 days. Can you please review now? |
@anikethsaha Can you check now? |
I will check this weekend. Thank you for your patience |
Bro, I think, contributed to a dead project. |
apologies for delay. Did you test locally is there any issue in that ? I didn't check locally, have some issue with my current OS config. |
I had checked when I fixed this. It was working fine. |
fixes #133