New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Jank when naviating to `FolderVideoPickerScreen` #260

Merged

anilbeesetti merged 2 commits into main from fix/videos-screen-jank

May 22, 2023

Owner

anilbeesetti commented May 21, 2023

The app experiences jank when videosState updates before the initial render finishes when navigating to FolderVideoPickerScreen

This pr fixes this by adding

collectAsStateWithLifecycle(minActiveState = Lifecycle.State.RESUMED)

By adding Lifecycle.State.RESUMED, we ensure that we wait until the first render completes.

anilbeesetti added 2 commits

May 21, 2023 17:04


          fix: jank when navigating to FolderVideoPickerScreen

2f28fb1


          lint: run ktlintFormat

05af9be

anilbeesetti merged commit e3f407d into main

3 checks passed

anilbeesetti deleted the fix/videos-screen-jank branch

May 22, 2023 04:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment