Feat: Add support for external subtitles #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
anilbeesetti
commented
Jun 3, 2023
•
anilbeesetti
commented
- At this point in time user can select external subtitles by long pressing subtitle icon button.
- NOTE: the external subtitles are not remembered between player sessions. This feature will be added in future pull request
- for [Request] Subs selection improvements #284
|
What about embedded subtitles (I mean subtitles integrated with the video without the need for a separate subtitle file)? The application does not support it. |
|
@AI-IMED Those are supported. Aren't they working for you. Can you send me a sample |
|
The embedded translations began to appear for me, I do not know the reason that prevented them from appearing in the past, but it seems to me that the position of the translations is very low
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.