Add support for monochrome icon (Android 13+ only) #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@milindgoel15, Try rebasing or merging main branch to pull latest changes. It will build now |
Yep does now. This is how it will look. What do you think? First one is with stroke width 3 and second is 4. i think 4 is better. 
|
|
Check this: I think it is better, don't you think |
|
Yep filled is okay too. |
|
The viewport height and width aren't as per Google android docs. So do make sure ur icon fits perfectly in all devices. Different viewports can mess up icons on custom skins like MIUI. |
|
Thanks for the suggestion. So far i didn't encounter any issues with the icon. But i'll look into docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #396
I was not able to test on a real device as Android Studio won't let me build the project even the debug build due to some ffmpeg error
Let me know if the icon needs adjustments or needs to reduce/increase size.